-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(minify): upgrade terser to v5, etc. #20
fix(minify): upgrade terser to v5, etc. #20
Conversation
It would be awesome if you want to put this info into the commit message. Unfortunately #18 (remove Node.js pre-14 support) seems to be a prerequisite for this. I may do this soon. I may have a few more nits coming on this, and some more comments coming on original issue #17. P.S. Adding a link to related issue: TrySound#61 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
My one major criticism is the use of "next" as ES2020 would be 2-3 years old by now.
IMHO adding tests is not as important when updating dependencies. I think tests are way more important when making bug fixes or adding new features.
It looks to me like this proposal includes several related items, which is why I added ", etc." to the title of this PR:
- update Terser to v5
- add test of ES2020
- test with updated @rollup/plugin-terser
- update README.md with updated @rollup/plugin-terser
@Francois-Esquire I have just released another patch and started version 0.14.0 with minimum Node.js version 14. I would like to get the terser v5 upgrade out pretty soon. If you can rebase this and address my comments soon then I can merge it in. Otherwise I may just do this upgrade without the test case. I will start updating some other dependencies now. |
@Francois-Esquire never mind, I am taking the liberty to fix this up myself and will merge this as a squash commit. I would like to get this finished soon. Thanks and apologies. |
@brodybits Thanks so much for taking the lead on this, truly appreciate it! And thanks for staying committed to this package, has been a huge help for us 🙌 |
These updates are now published in v0.14.1 (0.14.0 was published with missing contents). FYI I am currently available for short-term and long-term opportunities in case anyone in your organization may be interested, private contact chris.brody@gmail.com. |
This PR upgrades
terser
to v5 and adds a test case to test for ES2020 syntax (specifically optional chaining). Relates to issue #17 and #19.