Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnet4 #3

Merged
merged 7 commits into from Nov 30, 2016
Merged

Dotnet4 #3

merged 7 commits into from Nov 30, 2016

Conversation

TerribleDev
Copy link
Member

@dxwu mind looking over this PR for me?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 59.807% when pulling 8dc5be3 on dotnet4 into aecda26 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 59.807% when pulling 8dc5be3 on dotnet4 into aecda26 on master.

@dxwu
Copy link

dxwu commented Nov 29, 2016

looks awesome! I'll be working on using this for a net40 project today

dxwu
dxwu approved these changes Nov 29, 2016
View reviewed changes
Copy link

@dxwu dxwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- you don't have coverage of TplFactory functions but unit tests for those might be tricky.

@coveralls
Copy link

Coverage Status

Coverage increased (+10.03%) to 70.032% when pulling 0638efe on dotnet4 into aecda26 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+10.03%) to 70.032% when pulling f5f2ac4 on dotnet4 into aecda26 on master.

@TerribleDev TerribleDev merged commit f5f2ac4 into master Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dxwu dxwu dxwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TerribleDev @coveralls @dxwu