Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple problems (armor and tools not hiding) #6

Closed
Ferrlius opened this issue May 26, 2023 · 4 comments
Closed

Multiple problems (armor and tools not hiding) #6

Ferrlius opened this issue May 26, 2023 · 4 comments
Labels
bug Something isn't working question Further information is requested

Comments

@Ferrlius
Copy link

Describe the bug

ok I have a several problems.

  • I changed activation distance and by some reason armor and tools is no longer hiding
  • I play with from the fog and I think this mod causing modified entity error.
  • is there a way to fix enderman, spider and creeper spawning? it doesn't make sense why this 3 mobs should have that animation at all, and on enderman and spider it looks bad
    image
    image
    image

Steps to reproduce

I don't know why armor and tools doing that, I did everything right.
maybe it happened because I've made 92 blocks distance and then switched to 48?
I tried to switch "hide armor and tools" off and on and it did nothing

Expected behavior

armor and tools should be hided i guess

Additional context

1.19.2
simulation distance 5 chunks
@Ferrlius Ferrlius added the bug Something isn't working label May 26, 2023
@Tschipcraft
Copy link
Owner

Tschipcraft commented May 26, 2023 •
edited

The Hide worn armor and tools setting is only checked when a new entity is hidden. So switching the setting on and off will not yield results, only new entities will follow the chosen setting. It may have happened since your Simulation Distance is pretty low compared to the previous activation distance. Please try to reset the data pack in the menu (accessible via /trigger tschipcraft.menu) or directly with the command /function spawnanimations:reset to unhide already hidden mobs. All new mobs should afterward hide their armor and tools.

I tested Spawn Animations with From the Fog v1.9, and they seem to work fine together. Do you have any other data packs or mods installed?

For your third question, please take a look at the wiki on how to exclude entities from the animation. If you have animation ideas for these mobs that would fit them better, feel free to share them.

@Ferrlius
Copy link
Author

Ok thank you, I will try to apply changes today. So simulation distance can affect it... I was actually trying to use it as a mob freezer so they wouldn't create footprints

mods that modify entities? yeah my modpack made on Fabulously Optimized, and I have Spiders 2.0. I think that problem been there before I added spider mod but I might be wrong.

@Tschipcraft
Copy link
Owner

Tschipcraft commented Jun 26, 2023 •
edited

Are you still experiencing issues with Spawn Animations, or did the provided solution work?

@Tschipcraft Tschipcraft added the question Further information is requested label Jun 26, 2023
Tschipcraft added a commit that referenced this issue Aug 28, 2023
@Tschipcraft
Add recovery function for modified hidden entities
f28c66e 
- Added a recovery function for modified hidden entities that appends newly post-spawn items to the already existing data for hiding worn armor and tools. If the feet or leg slot itself gets modified, the warning message still triggers. This change hopefully increases compatibility (#6) and lessens the chance to see the warning message itself (#14)
- Restructured data pack
- Fixed broken damage trigger in mc1.19.4 and above
- Added server-side notice in the README (first steps for #8)
@Tschipcraft
Copy link
Owner

I closed this issue for now.
Feel free to reopen this issue, if you're still experiencing problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tschipcraft @Ferrlius