Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[n-upload] remove icon is missing in image-card mode while set max = 1 #1401

Closed
greenhat616 opened this issue Oct 19, 2021 · 0 comments
Closed

[n-upload] remove icon is missing in image-card mode while set max = 1 #1401

greenhat616 opened this issue Oct 19, 2021 · 0 comments
Labels
untriaged need to sort

Comments

@greenhat616
Copy link
Contributor

TuSimple/naive-ui version (版本)

2.19.9

Vue version (Vue 版本)

3.2.20

Browser and its version (浏览器及其版本)

Chrome Stable Latest

System and its version (系统及其版本)

Windows 11

Node version (Node 版本)

16 Latest

Reappearance link (重现链接)

https://gist.github.com/greenhat616/8a9be78bc51a519d0d282df1a2011b0b

Reappearance steps (重现步骤)

  1. use a n-upload component, set the max property to 1, and set type to image-card
  2. upload a img
  3. the image is forbidden to delete

Expected results (期望的结果)

the image can be deleted

Actual results (实际的结果)

remove icon is missing in image-card mode while set max = 1

Remarks (补充说明)
@github-actions github-actions bot added the untriaged need to sort label Oct 19, 2021
@Talljack Talljack mentioned this issue Oct 20, 2021
Closed
07akioni pushed a commit that referenced this issue Oct 20, 2021
fix(upload): file can't be removed when file count limit is reached, c…
358b279 
…loses #1401
07akioni added a commit that referenced this issue Oct 21, 2021
@07akioni
fix(upload): file can't be removed when file count limit is reached, c…
439f265 
…loses #1401
07akioni pushed a commit that referenced this issue Oct 21, 2021
@nooooooom @songjianet @XieZongChen
feat(color-picker): add show-color-preview prop (#1395)
9978d92 
* feat(color-picker): add `color-preview`

* docs(color-picker): add docs

* docs(color-picker): replace symbols

* feat(color-picker): `color-picker-swatches` support keyboard selection

* fix: guarantee test pass

* chore: use `toUpperCase`

* feat(color-picker): add `show-preview` prop

* chore(color-picker): public color convert function

* chore: keep uppercase

* docs(color-picker): document with color preview

* chore(color-picker): correct the variable name

* docs(color-picker): update docs

* refactor(tabs): on-before-leave prop

* fix(tabs): typo

* fix(upload): file can't be removed when file count limit is reached, closes #1401

* 2.19.11

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* chore: correct prop

Co-authored-by: 张乐聪 <zhanglecong@bytedance.com>
Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: XieZongChen <46394163+amadeus711@users.noreply.github.com>
07akioni added a commit that referenced this issue Oct 26, 2021
@XieZongChen @songjianet @07akioni
feat(data-table): refactor virtual-scroll (#1295)
44fd457 
* refactor(tabs): on-before-leave prop

* fix(tabs): typo

* fix(upload): file can't be removed when file count limit is reached, closes #1401

* 2.19.11

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* feat(data-table): restructure virtual-scroll

* feat(data-table): optimization

* feat: optimization

* feat(data-table): optimization expanded

* feat: optimization

* feat: optimization

* feat: optimization

* feat: optimization

* feat: optimization

* feat: add change log

* Update src/data-table/src/TableParts/Body.tsx

Co-authored-by: 张乐聪 <zhanglecong@bytedance.com>
Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
07akioni pushed a commit that referenced this issue Oct 27, 2021
@XieZongChen @songjianet
fix(input): text type doesn't support count slot (#1452)
ba11d25 
* refactor(tabs): on-before-leave prop

* fix(tabs): typo

* fix(upload): file can't be removed when file count limit is reached, closes #1401

* 2.19.11

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* feat(input): n-input add categories supported by const slots

Co-authored-by: 张乐聪 <zhanglecong@bytedance.com>
Co-authored-by: songjianet <1778651752@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
untriaged need to sort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greenhat616