Add a subscribe button to empty feed #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schmiddiii
force-pushed
the
feed-subscribe-button
branch
from
45107f9
to
e98f5ad
Compare
Schmiddiii
changed the title
TheEvilSkeleton
suggested changes
Mar 24, 2023
Co-authored-by: Hari Rana <theevilskeleton@riseup.net>
|
To be honest, I think the suggestive highlighting of the button is too much. |
|
That's normal design for GNOME apps that have an empty startup nowadays; Loupe, Bottles, etc. do that |
TheEvilSkeleton
suggested changes
Mar 24, 2023
Co-authored-by: Hari Rana <theevilskeleton@riseup.net>
|
Should we maybe do a similar thing in the filters and subscriptions pages? |
|
Absolutely! I didn't think of that, but yes, that would be great |
TheEvilSkeleton
suggested changes
Mar 26, 2023
Co-authored-by: Hari Rana <theevilskeleton@riseup.net>
About that, if you don't like how it looks, then you can always remove the style. You maintain and develop it after all |
TheEvilSkeleton
suggested changes
Mar 27, 2023
Co-authored-by: Hari Rana <theevilskeleton@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Licensing
Description
This adds a "subscribe"-button to an empty feed page.
Ping @TheEvilSkeleton if anything can be improved in this regard.
Linked Issue
Related to #95.