Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): enlarge time to wait for envoy #3

Merged
merged 1 commit into from
Dec 27, 2017
Merged

fix(test): enlarge time to wait for envoy #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ For developing or running test of this library, you probably need to:
1. have an envoy binary in your `PATH`, or:
```shell
$ npm run download-envoy
$ export export PATH=./node_modules/.bin/:$PATH
$ export PATH=./node_modules/.bin/:$PATH
```
2. there is a bug in gRPC's typing, run the following to fix it:
```shell
Expand All @@ -268,9 +268,8 @@ For developing or running test of this library, you probably need to:
3. to commit your code change:
```shell
$ git add . # or the things you want to commit
$ npm run commit
$ npm run commit # and answer the commit message accordingly
```
and answer the commit message accordingly.

## License

Expand Down
2 changes: 1 addition & 1 deletion test/lib/common-test-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export default abstract class CommonTestServer {
}
});
// wait for envoy to be up
await sleep(50);
await sleep(100);
}

async stop() {
Expand Down