Skip to content

Commit

Permalink
fixed typo with cache disable variable
Browse files Browse the repository at this point in the history
- fixed gap/missing label number
- changed bundle script to have a more cross-platoform shabang
- tweaked description for option
  • Loading branch information
JPvRiel committed Sep 16, 2017
1 parent 057805d commit 85cb57a
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion bundle.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/bash
#!/usr/bin/env bash
zip -r bundle.zip \
extension.js \
locale/ \
Expand Down
4 changes: 2 additions & 2 deletions extension.js
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ const ClipboardIndicator = Lang.Class({
},

_updateCache: function () {
if (DISABLE_CACHE_FILE) return; // disable file cache
if (CACHE_FILE_DISABLE) return; // disable file cache

writeRegistry(this.clipItemsRadioGroup.map(function (menuItem) {
return menuItem.clipContents;
Expand Down Expand Up @@ -398,7 +398,7 @@ const ClipboardIndicator = Lang.Class({
TIMEOUT_MS = this._settings.get_int(Prefs.Fields.INTERVAL);
MAX_REGISTRY_LENGTH = this._settings.get_int(Prefs.Fields.HISTORY_SIZE);
MAX_ENTRY_LENGTH = this._settings.get_int(Prefs.Fields.PREVIEW_SIZE);
DISABLE_CACHE_FILE = this._settings.get_boolean(Prefs.Fields.DISABLE_CACHE_FILE);
CACHE_FILE_DISABLE = this._settings.get_boolean(Prefs.Fields.CACHE_FILE_DISABLE);
DELETE_ENABLED = this._settings.get_boolean(Prefs.Fields.DELETE);
NOTIFY_ON_COPY = this._settings.get_boolean(Prefs.Fields.NOTIFY_ON_COPY);
ENABLE_KEYBINDING = this._settings.get_boolean(Prefs.Fields.ENABLE_KEYBINDING);
Expand Down
6 changes: 3 additions & 3 deletions prefs.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const Fields = {
HISTORY_SIZE : 'history-size',
PREVIEW_SIZE : 'preview-size',
CACHE_FILE_SIZE : 'cache-size',
DISABLE_CACHE_FILE : 'cache-disable',
CACHE_FILE_DISABLE : 'cache-disable',
DELETE : 'enable-deletion',
NOTIFY_ON_COPY : 'notify-on-copy',
ENABLE_KEYBINDING : 'enable-keybindings'
Expand Down Expand Up @@ -146,8 +146,8 @@ const App = new Lang.Class({
this.main.attach(cacheSizeLabel , 2, 4, 2 ,1);
this.main.attach(cacheDisableLabel , 2, 5, 2 ,1);
//this.main.attach(deleteLabel , 2, 4, 2 ,1);
this.main.attach(notificationLabel , 2, 7, 2 ,1);
this.main.attach(keybindingLabel , 2, 8, 2 ,1);
this.main.attach(notificationLabel , 2, 6, 2 ,1);
this.main.attach(keybindingLabel , 2, 7, 2 ,1);

this.main.attach(this.field_size , 4, 1, 2, 1);
this.main.attach(this.field_preview_size , 4, 2, 2, 1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@
<default>false</default>
<summary>Disable the registry cache file and use memory only</summary>
<description>
If true, content is not stored and retrieved from a cache (registry.txt) file. If the extension is reloaded, then your copy paste history is lost. However, if you copy and paste passwords, then this helps avoid writing them to a plaintext file.
Content is not stored and retrieved from a cache (registry.txt) file.
This avoid writing passwords to a plaintext file, but at the cost of persistant history.
Your clipboard history is lost after a gnome-shell session ends or the extension is reloaded.
</description>
</key>

Expand Down

0 comments on commit 85cb57a

Please sign in to comment.