Gnome Shell 40 Port

[jrahmatzadeh]

extension.js

Removed the deprecated actor for ClipboardIndicator.

prefs.js

• Gtk.accelerator_parse() now returns first element as ok.
• show_all() no longer works and needed on GTK4.
• Instead of HBox use Gtk.Box.
• margin no longer supported in GTK4 and replaced with more detailed margin properties.

metadata.json

Removed "3.38" and added "40.0" to the shell version.

[frandieguez]

Hope we get this PR merged. I have a similar PR from some days ago but I don't know if it was enough to be merged... #277

[jrahmatzadeh]

@frandieguez Sorry, didn't see that one. I'm just going over all popular extensions and porting them.

btw, we don't need show_all() and we don't need to check that with typeof. dropping that is safe for GNOME Shell +3.36.

Anyway, we shouldn't add 3.36 and 3.38 support for this one since I've mentioned about Gtk.accelerator_parse(). I've added this one to the port guide too and soon will be public.

If supporting older versions is the end, I can add version checking.

[prateekmedia]

@justperfection Please also get rid of dropdown button as it looks ugly with gnome 40 design and also because they removed it from the power and network strip.

[jrahmatzadeh]

@prateekmedia the prefs has dropdown visibility option and works on GNOME Shell 40.

[prateekmedia]

@justperfection I don't know enough, but I had done the same i.e. 40, 41, 42 for my extension without .0 , but it is showing incompatible in EGO with gnome 40. Here's the link
https://extensions.gnome.org/review/23140

So I reverted back to 40.0 and so on...

[jrahmatzadeh]

@prateekmedia "40" is the accepted version since yesterday. This is only applies to the new submitted extensions and not pending for review extensions. I also change the official port guide.

[rmader]

@prateekmedia the prefs has dropdown visibility option and works on GNOME Shell 40.

@justperfection could you change the default behaviour to disabled, in order to match default 40? IMO it would be even cleaner to just drop the future, but that can probably wait a bit more.

[jrahmatzadeh]

@rmader done!

[abhaypatil2000]

@justperfection it doesn't work for arch linux. I git cloned your repo in extension folder and then restarted the gnome shell. And then opened extensions app and still it shows not compatible with your gnome version. I am using arch linux with gnome 40

[jrahmatzadeh]

@abhaypatil2000 because you are not using my gnome-shell-40 branch.

[RuiGuilherme]

Works on Arch;

Btw, it works fine with my patch for images support. #283

[verbalius]

tested on Arch and it works without problems. Keyboard shortcuts, all settings and notifications.

[rmader]

@Tudmotu would love to see you finding time to land this :)

In case you are busy with other stuff, maybe we could have additional maintainers (I'd be open to volunteer for that, probably others as well) or even move the extension to the officially supported ones (https://gitlab.gnome.org/GNOME/gnome-shell-extensions/) in order to keep it working on new GS versions.

[Tudmotu]

Thank you @justperfection for this PR! 👏 😃
This is very appreciated. Thank you. 🙏

[Tudmotu]

Uploaded to e.g.o, will hopefully be approved in the next couple of days.

[Tudmotu]

New version is now approved on e.g.o :)
Thanks everyone for pushing this fix