Cycle though history with keyboard

[odrevet]

In this revision Alt modifiers has been added to the schema and extension.js has the correct indentation so it shows what has been added compare to your version.

[Tudmotu]

Hey @odrevet,
Thank you for this feature, I would really like to merge this, but there are a few issues I see with the code:

• Please fix your indentation so to align the keys you've added (_bindShortcut, etc..) with the other keys of the object (_removeEntry, Name, Extends, etc..)
• Do not use var in Gnome Shell extensions. Replace all the var instances with let
• In lines 331, 352, you are using 'for-in' on an array. Use Array.forEach. Take a look at line 170 for an example.
• I mentioned it in the previous PR - Please add an option to modify the shortcuts. We do not want users to be bound by our decision. They might have custom shortcuts that collide, so they need to be able to change these shortcuts. A nice bonus would be to also add an option to completely disable the shortcuts.

[Tudmotu]

@odrevet - Awesome! :)
If you like, what we can do regarding the last issue (expose shortcuts in the settings), is merge the changes so far, and open a different ticket for exposing the shortcuts via settings, then you can work on that part separately.
What do you say?

[odrevet]

Ok let's do that !

2014-11-12 17:41 GMT+01:00 Yotam Bar-On notifications@github.com:

@odrevet https://github.com/odrevet - Awesome! :)
If you like, what we can do regarding the last issue (expose shortcuts in
the settings), is merge the changes so far, and open a different ticket for
exposing the shortcuts via settings, then you can work on that part
separately.
What do you say?

—
Reply to this email directly or view it on GitHub
#5 (comment)
.

[Tudmotu]

@odrevet - OK, I apologize, but two last things before I merge:

• If I restart Gnome-Shell, there is a black box that appears on the top left side of the screen. Can you look into that and see if you can fix it, so it won't appear?
• Please add these lines to the CSS file (for better readability of the popup):

font-size:2em;
padding:.5em;

[odrevet]

done. I also set a fixed width in the css

2014-11-12 18:07 GMT+01:00 Yotam Bar-On notifications@github.com:

@odrevet https://github.com/odrevet - OK, I apologize, but two last
things before I merge:

• If I restart Gnome-Shell, there is a black box that appears on the
  top left side of the screen. Can you look into that and see if you can fix
  it, so it won't appear?
• Please add these lines to the CSS file (for better readability of
  the popup):

font-size:2em;padding:.5em;

—
Reply to this email directly or view it on GitHub
#5 (comment)
.

[Tudmotu]

Thank you @odrevet :)
Great feature!

[odrevet]

thanks to you. Hope the folks on gnome.org will like it too !