add to-do comments

Tufin · Jun 21, 2022 · 66a8e66 · 66a8e66
1 parent 48c42f2
commit 66a8e66
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 0 deletions.
diff --git a/diff/callbacks_diff.go b/diff/callbacks_diff.go
@@ -31,6 +31,7 @@ func (diff *CallbacksDiff) removeNonBreaking() {
 		return
 	}
 
+	// TODO: check breaking conditions
 	diff.Added = nil
 }
 

diff --git a/diff/content_diff.go b/diff/content_diff.go
@@ -38,6 +38,7 @@ func (diff *ContentDiff) removeNonBreaking() {
 		return
 	}
 
+	// TODO: check breaking conditions
 	diff.MediaTypeAdded = nil
 }
 

diff --git a/diff/encodings_diff.go b/diff/encodings_diff.go
@@ -29,6 +29,7 @@ func (diff *EncodingsDiff) removeNonBreaking() {
 		return
 	}
 
+	// TODO: check breaking conditions
 	diff.Added = nil
 }
 

diff --git a/diff/headers_diff.go b/diff/headers_diff.go
@@ -30,6 +30,7 @@ func (headersDiff *HeadersDiff) removeNonBreaking() {
 		return
 	}
 
+	// TODO: check if we need to consider header.Required flags
 	headersDiff.Added = nil
 }
 

diff --git a/diff/parameters_diff.go b/diff/parameters_diff.go
@@ -30,6 +30,7 @@ func (parametersDiff *ParametersDiff) removeNonBreaking(params2 openapi3.Paramet
 		return
 	}
 
+	// TODO: check vs. SchemaDiff.removeChangedButNonRequiredProperties
 	parametersDiff.removeAddedButNonRequired(params2)
 }