fix: respect readOnly and writeOnly properties for required checks

[gssbzn]

Closes #126

Edit: the original approach was to filter only if not breaking changes but I though about it a bit better and I think it makes more sense to always filter readonly for a request type and write only for a response type since this is more aligned with the spec

[codecov-commenter]

Codecov Report

Merging #130 (b38ca8e) into main (789538a) will increase coverage by 0.02%.
The diff coverage is 91.37%.

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   89.49%   89.51%   +0.02%     
==========================================
  Files          70       70              
  Lines        3949     4043      +94     
==========================================
+ Hits         3534     3619      +85     
- Misses        298      303       +5     
- Partials      117      121       +4     

Flag	Coverage Δ
unittests	89.51% <91.37%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
diff/schema_diff.go	85.90% <87.17%> (-0.34%)	⬇️
diff/required_diff.go	95.89% <100.00%> (+3.99%)	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[gssbzn]

there's no nickname property, if this was intentional need to address this at the test level

[reuvenharrison]

:-)

[reuvenharrison]

Hi Gustavo,
Your contribution is great!

In addition to the scenario you addressed (adding/deleting properties from/to the RequiredProperties list), I implemented solutions for a couple more use-cases:

1. Adding/deleting properties
2. Modifying read/write only flags for existing properties

It would be great if you could take a look and verify these use-cases too.

Thanks,
Reuven

[gssbzn]

@reuvenharrison thanks for looking into this, I see you pushed some changes to address the comments and I just merged main to resolve some conflicts, is there anything else you think I should look into before getting it merge?