Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ruby 3 #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to Ruby 3 #30

wants to merge 1 commit into from

Conversation

rawOrlando
Copy link
Contributor

@rawOrlando rawOrlando commented Nov 7, 2023

This upgrades tufts spotlight to ruby 3.2.

It also meant upgrading

  • rails from 5 -> 7.0.2
  • blacklight 6 -> 7.35
  • blacklight spotlight 2.13 -> 3.4.4
  • bootstrap 3 -> 4

Login Changes

Login could no longer work how it previously did.
Omniauth no longer accepts GET requests when signing in.
The solution was to add a footer with a login option, as most users do not login we want to keep this out of the way.

@coveralls
Copy link

coveralls commented Feb 22, 2024

Pull Request Test Coverage Report for Build 9081968025

Details

  • 18 of 34 (52.94%) changed or added relevant lines in 7 files are covered.
  • 29 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-5.4%) to 41.237%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/helpers/spotlight_helper.rb 1 2 50.0%
app/controllers/omniauthcallbacks_controller.rb 0 2 0.0%
lib/tufts/hostname_fixer.rb 0 2 0.0%
app/services/spotlight/manifest_service.rb 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
app/models/tufts/tdl_resource.rb 1 69.23%
app/models/user.rb 1 47.62%
app/models/tufts/iiif_service.rb 7 0.0%
app/models/tufts/iiif_manifest.rb 20 0.0%
Totals Coverage Status
Change from base Build 5145158781: -5.4%
Covered Lines: 160
Relevant Lines: 388

💛 - Coveralls

@rawOrlando rawOrlando force-pushed the ruby-3-upgrade branch 11 times, most recently from f336cd3 to 61711f3 Compare May 13, 2024 18:06
@rawOrlando rawOrlando force-pushed the ruby-3-upgrade branch 3 times, most recently from 05ee38b to 8ba431b Compare May 21, 2024 17:59
@rawOrlando rawOrlando force-pushed the ruby-3-upgrade branch 7 times, most recently from 7d916fb to 20f879e Compare June 10, 2024 14:06
@rawOrlando rawOrlando force-pushed the ruby-3-upgrade branch 3 times, most recently from a2c362c to dde7c92 Compare June 18, 2024 15:49
@rawOrlando rawOrlando force-pushed the ruby-3-upgrade branch 2 times, most recently from 128cf1f to 849e58e Compare July 8, 2024 14:34
@rawOrlando
Copy link
Contributor Author

  • still need to look into js issue of Listener added for a DOMNodeInserted which this newer but old spotlight uses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants