Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BestieTemplate #50

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

greg-neustroev
Copy link
Collaborator

Changed CopierTemplate to BestieTemplate and ran BestieTemplate.update()

Closes #39

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.08%. Comparing base (a3f147a) to head (79792d1).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #50      +/-   ##
===========================================
- Coverage   100.00%   99.08%   -0.92%     
===========================================
  Files            5        5              
  Lines          219      218       -1     
===========================================
- Hits           219      216       -3     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greg-neustroev
Copy link
Collaborator Author

@abelsiqueira Lint checker fails because of this error:

Errors in .github/PULL_REQUEST_TEMPLATE.md

Error: Process completed with exit code 2.

This is because BestieTemplate changed contributing.md to 90-contributing.md, so the file does not exist currently. Should we ignore this check for now, since the file name will change in the very same PR?

Code coverage also is not passing anymore, but I have made a separate Issue #51 for it, it's a small fix and is not directly related to this PR.

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for testing Bestie. I've made a comment on a file that should be in .gitignore (there is an issue on Bestie), but for now it should be fine to add the lines in .gitignore and remove the file manually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in the .gitignore and it was removed.

.gitignore Outdated
Comment on lines 9 to 12
env
/.benchmarkci
/benchmark/*.json
coverage/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should remain, I've created an issue on Bestie for this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abelsiqueira I put it back

@abelsiqueira
Copy link
Member

Indeed the link failures are expected

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@abelsiqueira abelsiqueira merged commit 6a4a84e into TulipaEnergy:main Jul 4, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply BestieTemplate.jl
2 participants