-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide whether to use DataFrames as data structures or actual structs #118
Comments
We have several issues about dataframes, structs, namedtuples, dicts. According to this random person on the internet, dataframes aren't meant for data with named rows, which it seems like we have. Should we be using a different data storage type for our parameters and variables? Maybe immutable and mutable structs? Although the response above also sounds like tuples could be an option. I don't know what counts as a "smallish amount of objects." |
These issues are a bit related to https://jump.dev/JuMP.jl/stable/tutorials/getting_started/design_patterns_for_larger_models/ and the subsequent chapter on performance. The question for all these issues is where we'll stand in the balance between performance and readability (code readability and log readability). My short answer is to do what looks nicer but not obviously slow, and then benchmark/profile later. |
waiting on #110 |
Decide whether to use DataFrames as data structures or actual structs (using MetaGraphs.jl)
Maybe it is not necessary to use a separate dedicated struct to hold the data for the assets and edges since we are already reading these things from CSV files (probably into DataFrames). That means that they don't need a special structure, and therefore using the DataFrames directly should be viable.
Depends on:
The text was updated successfully, but these errors were encountered: