-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the explanation of the features (variable time resolution) #348
Update the explanation of the features (variable time resolution) #348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 296 296
=========================================
Hits 296 296 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Is this also fixing the variable time resolution test case?
Thanks! @clizbe, I changed the test case to cover one extra case we discussed with @g-moralesespana. So, the documentation and the test case match one to the other. |
Hi @datejada! I'm reading this part and have some minor comments...I still have a few other questions for my understanding though but we'd better discuss |
Pull request details
Describe the changes made in this pull request
List of related issues or pull requests
Closes #256
Collaboration confirmation
As a contributor I confirm