Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the explanation of the features (variable time resolution) #348

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

datejada
Copy link
Member

@datejada datejada commented Dec 8, 2023

Pull request details

Describe the changes made in this pull request

  • Updates the documentation of the variable time resolution
  • Update in the variable time resolution to cover more cases in the example

List of related issues or pull requests

Closes #256

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@datejada datejada requested a review from clizbe December 8, 2023 15:46
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de3b967) 100.00% compared to head (ac94516) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #348   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          296       296           
=========================================
  Hits           296       296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@clizbe clizbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Is this also fixing the variable time resolution test case?

@datejada
Copy link
Member Author

Thanks! @clizbe, I changed the test case to cover one extra case we discussed with @g-moralesespana. So, the documentation and the test case match one to the other.

@datejada datejada merged commit f5899c9 into TulipaEnergy:main Dec 11, 2023
6 checks passed
@datejada datejada deleted the 256-expand-explanation-features branch December 11, 2023 12:59
@gnawin
Copy link
Member

gnawin commented Dec 12, 2023

Hi @datejada! I'm reading this part and have some minor comments...I still have a few other questions for my understanding though but we'd better discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update formulation in the documentation with the ranges/matrices
3 participants