Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete function resolution_matrix #354

Conversation

gnawin
Copy link
Member

@gnawin gnawin commented Dec 13, 2023

Pull request details

Describe the changes made in this pull request

  • Remove function resolution_matrix
  • Remove its tests

List of related issues or pull requests

Closes #351

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56c8584) 100.00% compared to head (d39f334) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #354   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          293       290    -3     
=========================================
- Hits           293       290    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnawin gnawin requested a review from clizbe December 13, 2023 12:01
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@datejada datejada merged commit dc8e169 into TulipaEnergy:main Dec 13, 2023
6 checks passed
@gnawin gnawin deleted the 351-remove-obsolete-function-resolution-matrix branch February 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obsolete function resolution_matrix
2 participants