Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EU data with rep-periods-data.csv #365

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

abelsiqueira
Copy link
Member

Pull request details

Describe the changes made in this pull request

The EU data was not updated. I hope what I have here is the correct new file.
I have also added a call at the end of the tests to ensure that the EU data can be loaded. This should avoid errors like this in the future.

List of related issues or pull requests

Closes #364

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c07ff22) 100.00% compared to head (09c92ea) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          296       296           
=========================================
  Hits           296       296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Adding it to the tests will help to catch this earlier in the future.

@datejada datejada merged commit 0278d44 into TulipaEnergy:main Dec 15, 2023
5 checks passed
@abelsiqueira abelsiqueira deleted the 364-fix-eu-data branch December 15, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The EU data is not up-to-date
2 participants