Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the complete solution to CSV #491

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Feb 22, 2024

Pull request details

Describe the changes made in this pull request

Change the function save_solution_to_file to print the complete solution to files with appropriate names.
Stop saving the output in git.
Use Norse to test save_solution_to_file instead of Tiny, for completeness.

List of related issues or pull requests

Closes #295

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@abelsiqueira
Copy link
Member Author

I will do #490 and #492 before this.

@abelsiqueira abelsiqueira force-pushed the 295-save-solution-csv branch 2 times, most recently from 51cf4c8 to 2b0fe1a Compare February 22, 2024 15:01
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e166730) to head (9ac45ce).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #491   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          494       520   +26     
=========================================
+ Hits           494       520   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira marked this pull request as ready for review February 23, 2024 08:08
@abelsiqueira abelsiqueira added benchmark PR only - Run benchmark on PR and removed benchmark PR only - Run benchmark on PR labels Feb 23, 2024
Copy link
Member

@clizbe clizbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)
Really nice how it simplifies the docs too.

@abelsiqueira
Copy link
Member Author

Thanks for the review.

@abelsiqueira abelsiqueira merged commit de565b2 into TulipaEnergy:main Feb 23, 2024
8 checks passed
@abelsiqueira abelsiqueira deleted the 295-save-solution-csv branch February 23, 2024 12:29
@clizbe
Copy link
Member

clizbe commented Feb 23, 2024

Oh but you didn't check the boxes. >.>

@abelsiqueira
Copy link
Member Author

@abelsiqueira abelsiqueira mentioned this pull request Feb 27, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a function to export the whole solution to file (e.g., CSV, parquet, JSON, etc.)
2 participants