-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save the complete solution to CSV #491
Save the complete solution to CSV #491
Conversation
51cf4c8
to
2b0fe1a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 494 520 +26
=========================================
+ Hits 494 520 +26 ☔ View full report in Codecov by Sentry. |
2b0fe1a
to
9ac45ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
Really nice how it simplifies the docs too.
Thanks for the review. |
Oh but you didn't check the boxes. >.> |
Pull request details
Describe the changes made in this pull request
Change the function
save_solution_to_file
to print the complete solution to files with appropriate names.Stop saving the output in git.
Use Norse to test
save_solution_to_file
instead of Tiny, for completeness.List of related issues or pull requests
Closes #295
Collaboration confirmation
As a contributor I confirm