Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review docs #572

Merged
merged 9 commits into from
Mar 29, 2024
Merged

Review docs #572

merged 9 commits into from
Mar 29, 2024

Conversation

clizbe
Copy link
Member

@clizbe clizbe commented Mar 28, 2024

Pull request details

Describe the changes made in this pull request

List of related issues or pull requests

Closes #467

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • [NA] Tests are passing
  • Lint is passing

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (af159fc) to head (a107f11).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #572   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          628       628           
=========================================
  Hits           628       628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clizbe clizbe marked this pull request as ready for review March 29, 2024 16:12
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 😃

@datejada datejada merged commit 42d9768 into TulipaEnergy:main Mar 29, 2024
7 checks passed
@clizbe clizbe deleted the 467_review_docs branch May 7, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review documentation for Q1 release
2 participants