Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing .NET version #21

Closed
bastrakov-sergei opened this issue Mar 29, 2017 · 6 comments
Closed

Reducing .NET version #21

bastrakov-sergei opened this issue Mar 29, 2017 · 6 comments

Comments

@bastrakov-sergei
Copy link

bastrakov-sergei commented Mar 29, 2017

Hello,

Your library successfully build with 3.5 .Net framwork version. It is possible to reduce framework version in project settings to 3.5? There no reason to use 4.6.1. Or you can make several versions with different .Net framework.
Also can you specify restriction for .Net vesion in nuget package? Now I can install last package in 4.0 (for sample) project. And project is not building.

Thank you.

@ricardopolo
Copy link
Member

@sergey-bastrakov @cmeuzelaar I need your help for understanding what should I do here.

In #21 you ask to downgrade the .Net.
In #17 you as to upgrade it.

So, how should we manage this? Do you know what is the best practice about versioning Nugets?

Thanks and regards

@MarcelGosselin
Copy link
Contributor

I think we should target the lowest version of .NET on which it builds and runs succesfully. That way an application using the library can target any framework starting at that one. With current code, we force every user to use .NET 4.6.1 or more.
So go for .NET 3.5.
My 2¢

@HelOWeen
Copy link

HelOWeen commented Apr 6, 2017

@MarcelGosselin: Agreed, downgrading to the lowest possible .NET seems to be the sensible thing to do.

Especially since .NET 4.6.x is only included with the VS2017 (https://www.microsoft.com/net/targeting). Using it in its current form would force the distribution of .NET 4.6.1 along with the application (for OS < Windows 10).

@cmeuzelaar
Copy link

4.6.1 is available with 2015 (using it in my office), but I'd personally prefer a NuGet with a .NET 3.5 and a .NET 4.0 version since Windows 8+ do not ship with .NET 3.5 enabled by default. I have an example of how to do this to the project, but am incredibly unfamiliar with how to submit it to GitHub.

@ricardopolo
Copy link
Member

All right, thank you everyone for your answers. Can anyone help me please with this?
In my machine (W10) the lowest available .NET is 4.

So a PR compiling with and older version of .Net will be happy merged! :)

@HelOWeen
Copy link

I cloned the project and tried a recompile with .NET 3.5 and 4.5, but I get an error complaining about the ActiveDS typelib. I've tried removing the project's reference and reinserting, but to no avail. I'm on Windows 7 64-bit, so I guess I'm lacking the proper version of the TLB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants