Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Twitter profile and banner images #189

Open
thomas694 opened this issue Nov 20, 2021 · 7 comments
Open

Download Twitter profile and banner images #189

thomas694 opened this issue Nov 20, 2021 · 7 comments
Labels
beginner Estimated level of difficulty enhancement New feature or request first-timers-only an easy issue for first time contributors only good first issue Good for newcomers

Comments

@thomas694
Copy link
Contributor

Is your feature request related to a problem? Please describe.
At the moment the Twitter downloader isn't downloading the banner and profile images of the downloaded blog.

Describe the solution you'd like
I would like that the profile and banner images of a blog are downloaded too. New images shouldn't overwrite the previous ones. And maybe they could be grouped together somehow so that they are not distributed across the whole folder.

Describe alternatives you've considered
Downloading by hand is not easily possible as it needs actively looking for changes.

Additional context

@thomas694
Copy link
Contributor Author

As before this one is for first-timers-only. That means that we will only accept a PR for this one from someone who's never contributed to open source before. This one is particularly easy (but don't make that statement make you feel bad if you have a hard time with it, there's more to contributing to open source than changing lines of code, especially if it's your first time). We walk you through it if you need help. :-) Here are the steps to get a PR merged (see also our guide).

When downloading a Twitter blog its banner and profile images shall be downloaded too. Old versions shall not be overwritten and new versions shall only be downloaded/saved if they really changed.

  • Create a fork of the repository
  • Clone it to your local disk and create a new branch (e.g. 189-download-profile-images)
  • Look which class is dealing with the Twitter blog download. Where is the entry method of the Twitter crawler? What needs to be done to download these images? Do the filenames change or not if the blog owner changes the images? How can it be solved?
  • Add your solution
  • Build the app and run it
  • Create yourself a test blog where you can change the banner and profile images for testing
  • Alternatively: simulate previously downloaded banner/profile images of another blog by using different renamed test images
  • Crawl/Download the blog again
  • Verify that the changed profile and banner images have been downloaded
  • Commit your changes mentioning "issue #189" somewhere in your commit message title or description
  • Push your changes to your fork, create a PR, get merged, celebrate??

We are happy to support you if you need help.

@thomas694 thomas694 added beginner Estimated level of difficulty enhancement New feature or request first-timers-only an easy issue for first time contributors only good first issue Good for newcomers labels Nov 20, 2021
@SantruptaMishra98
Copy link

Hi, looking into trying to solve the issue.

@thomas694
Copy link
Contributor Author

Hello,
thanks for your interest to work on this issue. I assign it to you.
If you have a question or get stuck, feel free to ask.

@thomas694
Copy link
Contributor Author

@SantruptaMishra98
Hi, do you have any questions?

@kulesy
Copy link
Contributor

kulesy commented Feb 7, 2022

Ill give this issue a go as it seems @SantruptaMishra98 is inactive.

@thomas694
Copy link
Contributor Author

Yes, seems so. So it can be taken by a new volunteer.

Thanks for your interest. But if we'd stick closely to our rules, you'd not qualify as a first-time contributor.
Do you like to solve e.g. #206 or #211 instead?

@kulesy
Copy link
Contributor

kulesy commented Feb 7, 2022

Okay, I'll try to solve #206.

@Mannuel25 Mannuel25 converted this issue into a discussion Aug 27, 2022
@thomas694 thomas694 reopened this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Estimated level of difficulty enhancement New feature or request first-timers-only an easy issue for first time contributors only good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants