-
Notifications
You must be signed in to change notification settings - Fork 72
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downloaded Twitter images are capped in resolution #211
Comments
Why are you breaking your silence after so many months? /s 😉 🙂 Thanks for bringing it to our attention. We'll have a look at it. |
Sorry, been a bit busy. I would've posted yesterday, but the limit issue was still in effect. Here are two images that while not the most the site can offer, does show the issue fairly well: https://pbs.twimg.com/media/FJEIq6_VcAABBVz?format=jpg&name=4096x4096 (website copy) |
Thanks for the examples. |
Also, I don't know if this is related at all, but I did notice downloaded video thumbnails being higher resolution than the actual video files themselves. I'm not sure if it's a genuine glitch or an accidental up-res on the crawler's end, but I thought I should mention it. |
- Some high resolution images were capped when downloaded. - Now the app is trying to download the best quality, if setting is set. Fix issue #211 Video thumbnails downloaded in "higher" resolution than video - The app requested a high resolution image and Twitter kindly delivered (an upscaled) one. - Only the offered thumbnail is downloaded now.
As you found out there was a problem with very high resolution images. Now there exists a new image category "best" for downloading them. Of course, a thumbnail image in a higher resolution than the video doesn't make much sense. The app just always requested a high resolution image and Twitter kindly delivered (an upscaled) one. Only the original thumbnail is downloaded now. |
The issue has been fixed and closed. You can still comment. Feel free to ask for reopening the issue if needed. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Describe the bug
I've noticed since the Twitter crawler was introduced that many of the higher resolution images end up having the limit of 2048 for length/width/both. Kind of similar to the issue the Tumblr crawler was having, but this one is more consistent from picture to picture.
To Reproduce
Grab a copy of a hi res image off the website and compare to the copy the crawler produces.
Expected behavior
The image from the crawler gets to 2048 maximum at either length, width, or both.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: