Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delimiting commas between objects when saving blog metadata as JSON #82

Closed
mamift opened this issue Sep 5, 2020 · 2 comments
Closed

Comments

@mamift
Copy link

mamift commented Sep 5, 2020

Currently, when choosing to save blog metadata as JSON, it saves the metadata as text files, but for some reason omits delimiting commas for individual post objects (after the } closing off one object, but before another { beginning a new object). It does add them for individual object properties. Here's what I mean (taking an excerpt of images.txt):

{
  "video-player-500": "",
  "video-source": "",
  "width":  937
}

{
  "answer": "",
  "audio-capt: "",
}

To view all instances in a text editor, the regex search for it is: }\n{.

Is it possible to implement a change to add those delimiting commas when downloading a Tumblr blog using JSON as the metadata format? This would make it more parsable.

thomas694 added a commit that referenced this issue Oct 3, 2020
…g metadata as JSON

- When choosing metadata format JSON, the text files are not written in proper JSON (missing array brackets and delimiting commas).
- At the moment only delimiting commas have been added, because array brackets would need a bigger code change.
- So, if you want to use the JSON files in another program or JSON editor, you have to remove the last comma and put brackets around the whole content.
@thomas694
Copy link
Contributor

At the moment only delimiting commas have been added, because array brackets would need a bigger code change.
So, if you want to use the JSON files in another program or JSON editor, you have to remove the last comma and put brackets around the whole content.

@thomas694
Copy link
Contributor

The issue has been closed. You can still comment. Feel free to ask for reopening the issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants