reset preferences window animation #537
Conversation
* reset preferences window animation time * fix overlay content issues when navigation between * 📕 https://developer.apple.com/design/human-interface-guidelines/macos/app-architecture/preferences/ * fixes #522
|
@jkbullard I know, is a dirty hack resetting the animation duration. What is your opinion on this? |
|
I agree, resetting the duration to zero is pretty hackish; one might just as well disable the code entirely. (Or even strip out the entire DBPrefsWindowController/MyPrefsWindowController classes, because as I recall the reason they were used was to do this animation.) So I'd prefer something that instead fixes the problem but preserves the automation; that is, that fades the old view out and then fades the new view in. (I'm assuming that the current code does both simultaneously and that's what's causing the problem.) That may be more trouble than it's worth but should be looked into. I haven't seen this problem myself, although I've seen the screenshot in #522 and a movie of it happening, so it may depend on hardware speeds or something like that. (Although why Apple would make animation that depends on hardware speed I don't understand. Maybe it's due to a change in macOS's automation instead?) |
|
Thank you for this detailed explanation. 🙇♂️ I do not have the Obj-C skills to refactor all the |
…window Similar to #537 by @m5o but changes only on Mojave and higher. On macOS Mojave and higher, switching panels in the VPN Details window nowhappens instantly, which avoids the problem introduced in Mojave that caused macOS to ignore the "fade in" time. On macOS El Capitan and lower, the panel switching behavior does not change: the panels are faded smoothly from one to another.
🔗 #528