Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Swipe gesture icon position #121

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mvietri
Copy link

@mvietri mvietri commented Nov 12, 2019

@Tunous I can't build Dank anymore since the last commits. I've tried everything by now. So I can't check if this stills works.. I've recover this branch using git reflog. It does build but it does not run on my phone.

icon position

Closes #18

@Tunous
Copy link
Owner

Tunous commented Nov 13, 2019

I can't build Dank anymore since the last commits.

What is the error that you are getting?

@tunous-bot
Copy link

Test version of Dank has been automatically built from this pull request.
Click here to download it.

@mvietri
Copy link
Author

mvietri commented Nov 13, 2019

Well.. I can't run that apk either.

It crashes upon launch. Logcat yields this saket#18

I've tried invalidating caché, deleting folders, even checking out the project again. My 'multiple accounts' branch which is several commits behind master, builds and runs ok. But on master I get the same result as the bot just built

@Tunous
Copy link
Owner

Tunous commented Nov 13, 2019

Can you check whether changing dependency like done here: slapperwan/gh4a@e34181f would fix the issue?

@mvietri
Copy link
Author

mvietri commented Nov 13, 2019

@Tunous I'll try it that. Can you install and run this APK?

@Tunous
Copy link
Owner

Tunous commented Nov 13, 2019

The one from this build also doesn't build for me. I'm pretty sure that's the issue with this library but didn't test how it works with the alternative.

@mvietri
Copy link
Author

mvietri commented Nov 13, 2019

The one from this build also doesn't build for me. I'm pretty sure that's the issue with this library but didn't test how it works with the alternative.

Ok. I'll check that because master branch is broken at least for me. Thanks.

@Tunous Tunous added the feature New feature label Nov 13, 2019
@mvietri
Copy link
Author

mvietri commented Nov 13, 2019

Can you check whether changing dependency like done here: slapperwan/gh4a@e34181f would fix the issue?

Yes, that works. I've tested on this branch and works just fine.

- Cannot click links in thread view
@mvietri
Copy link
Author

mvietri commented Nov 14, 2019

Another dep seems to be broken. Downloading images crash the app. It's not related to this branch, I built from master sources.

@tunous-bot
Copy link

Test version of Dank has been automatically built from this pull request.
Click here to download it.

Copy link
Owner

@Tunous Tunous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this would work nicely if the icon always stayed in the middle of the visible part of the comment instead of being positioned under the touch point.

@Tunous Tunous added the waiting Pull requests that require changes or issues that await response label Jun 13, 2020
@mvietri
Copy link
Author

mvietri commented Jun 19, 2020

@Tunous Sorry, I currently don't have any free time left to work on this PR.

@Tunous
Copy link
Owner

Tunous commented Jun 19, 2020

@Esselans No worries, as long as these changes are still here someone else can take them and continue on your work. I'll add help wanted label then to indicate that.

@Tunous Tunous added the help wanted Extra attention is needed label Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature help wanted Extra attention is needed waiting Pull requests that require changes or issues that await response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gestures' action icon position
3 participants