transform route and controller tests #70
Conversation
|
|
||
| describe('LoadingIndexRoute', function() { | ||
| setupTest('route:loading/index', { | ||
| // needs: ['service:ajax'] |
There was a problem hiding this comment.
Does this comment serve a purpose to the test? Like, is this to ensure comments are also removed?
There was a problem hiding this comment.
@rondale-sc indeed. I wanted to have a sample of what you might find in an older ember-mocha codebase. Not strictly necessarily, but fulfilling a goal of mine to test against real world snippets.
| function findOtherUnitTestSetup(nodePath) { | ||
| let hasSetup = j(nodePath).find(j.ExpressionStatement, { expression: { callee: { name: 'setupTest' } } } ) | ||
| let isRouteTest = hasSetup | ||
| && j.ExpressionStatement.check(nodePath) |
There was a problem hiding this comment.
Not something to hold the PR up for, but it might be nice having a little comment to the right of each line here to let future travelers know more easily what is going on here since this seems quite involved.
There was a problem hiding this comment.
Completely agreed! Hearty advice for most codemod authoring :).
|
This looks great! Thanks! 🍻 |
fix #69. Also fixes a bug with nested lifecycle hookds causing subjectContainerKey to be undefined.
|
LGTM - Will release on monday since I don't have npm creds on my new machine yet. |
ghost
deleted the
fix #69. Also fixes a bug with nested lifecycle hooks causing
subjectContainerKeyto be undefined.I tested these transforms against our application running ember-mocha@0.14. The transform work, but I am seeing a bunch of errors I can detail elsewhere.