Add OpenLayers v5/6 compatibility #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasG77
changed the title
Turbo87
reviewed
Nov 16, 2019
Turbo87
changed the title
Turbo87
changed the title
|
Just to say that I've just bumped into the issue with |
Turbo87
approved these changes
Nov 17, 2019
Open
paultcochrane
added a commit
to paultcochrane/sidebar-v2
that referenced
this pull request
Nov 28, 2019
This change implements the suggestion mentioned in Turbo87#156 to rename the source files from `ol3` to simply `ol` so as to reflect the compatibility from OpenLayers 3 up to and including OpenLayers 6. The example file as well as the documentation have been updated to be consistent with the filename generalisation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for OpenLayers 6 was failing due to
ol.inheritsremoval in OpenLayers 6 (release notes reference). I've made correction with a "if else" to manage code for both OpenLayers 5 and 6. My choice has been to not create a function as there was only one call toinheritsin theol3-sidebar.jsbase code. I've borrowed the logic from https://gis.stackexchange.com/a/324607 without using a function.Need a review.
A suggestion after this commit would be to remove reference to
ol3-sidebar.jsand rename it tool-sidebar.js, do the same forol3-sidebar.css(would beol-sidebar.css) and change the doc to mention OpenLayers 3+ (version is now 6.1.1)