Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-notifier dependency to v5.2.1 #36

Merged
merged 2 commits into from
Jan 5, 2018

Conversation

naidraikzir
Copy link
Contributor

@naidraikzir naidraikzir commented Jan 5, 2018

Github says Marked has a known moderate severity security vulnerability in version range < 0.3.9.
Here is the link CVE-2017-17461.
node-notifier v5.2.1 doesn't use marked anymore.

fix #35

@Turbo87
Copy link
Owner

Turbo87 commented Jan 5, 2018

Seems good to me, thanks! Can you remove the lockfile from the PR?

@naidraikzir
Copy link
Contributor Author

@Turbo87 Done 👍

@Turbo87 Turbo87 merged commit cf23963 into Turbo87:master Jan 5, 2018
@Turbo87
Copy link
Owner

Turbo87 commented Jan 5, 2018

Thanks :)

@fitztrev
Copy link

@Turbo87 Could you please tag a release that includes this?

@Turbo87
Copy link
Owner

Turbo87 commented Jan 10, 2018

I'm on vacation right now without my laptop so unfortunately the answer is no until I get back, sorry.

@fitztrev
Copy link

@Turbo87 no problem, it can wait 😄 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update node-notifier
3 participants