[#39] - python 2 cleanup

[kentontaylor]

No description provided.

[codecov]

Codecov Report

Merging #46 (810b445) into master (ae76cdd) will decrease coverage by 0.01%.
The diff coverage is 80.86%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   89.96%   89.95%   -0.02%     
==========================================
  Files          43       43              
  Lines        6636     6608      -28     
==========================================
- Hits         5970     5944      -26     
+ Misses        666      664       -2     

Flag	Coverage Δ
tests-3.5	?
tests-3.6	89.80% <80.86%> (-0.03%)	⬇️
tests-3.7	89.80% <80.86%> (-0.03%)	⬇️
tests-3.8	89.95% <80.86%> (-0.03%)	⬇️
tests-3.9	89.95% <80.86%> (-0.03%)	⬇️
tests-pypy3	89.80% <80.86%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
ming/tests/test_base.py	97.56% <ø> (-0.06%)	⬇️
ming/odm/middleware.py	73.68% <50.00%> (+1.88%)	⬆️
ming/odm/property.py	90.87% <60.00%> (-0.04%)	⬇️
ming/mim.py	78.65% <63.63%> (-0.03%)	⬇️
ming/metadata.py	85.56% <66.66%> (+0.43%)	⬆️
ming/odm/identity_map.py	92.59% <66.66%> (-0.27%)	⬇️
ming/schema.py	89.48% <67.74%> (-0.03%)	⬇️
ming/tests/test_mim.py	90.88% <70.00%> (ø)
ming/odm/odmsession.py	68.16% <71.42%> (ø)
ming/utils.py	71.69% <85.71%> (-0.53%)	⬇️
... and 24 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae76cdd...810b445. Read the comment docs.

[brondsem]

Looks like python 3.5 has test failures due to new syntax (see "Checks" tab or further below). I think it would be fine to drop it. Both 3.5 and 3.6 are end-of-life, but might as well keep py36 since its working. Places to update:

• setup.py: classifiers & python_requires
• tox.ini
• .github/workflows/main.yml

[brondsem]

That fixes the CI build. There's more feedback after my last comment though, its correlated with specific code lines, i think maybe you missed it?

[kentontaylor]

New commit addresses style cleanups, version bump, and mock lib removal.

[brondsem]

Merged