Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master.jinja template doesn't highlight tabs in navbar #10

Closed
devilicecream opened this issue Nov 20, 2017 · 1 comment
Closed

master.jinja template doesn't highlight tabs in navbar #10

devilicecream opened this issue Nov 20, 2017 · 1 comment

Comments

@devilicecream
Copy link
Contributor

There's a little bug in the master template for Jinja2, that assigns the active class to the anchor inside the li element, instead of the li itself in the top navbar.
The result is that the tabs in the top navbar never get highlighted.
devilicecream added a commit to devilicecream/tg2devtools that referenced this issue Nov 20, 2017
@devilicecream
Fix to TurboGears#10
b333537 
The proposed change fixes the little bug in issue TurboGears#10. This way tabs in the navbar will get highlighted when they're supposed to in the base quickstart TG2 application with Jinja2
@amol-
Copy link
Member

amol- commented Nov 22, 2017

I'll gladly merge a pull request if you can submit one. The jinja template is an external contribution I rarely use, so I really appreciate any fix for it jinja users can contribute.

@devilicecream devilicecream mentioned this issue Nov 22, 2017
Merged
amol- added a commit that referenced this issue Nov 22, 2017
@amol-
Merge pull request #11 from devilicecream/patch-1
47c9628 
Fix to #10
@amol- amol- closed this as completed Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amol- @devilicecream