Fix API problems (Newgrounds!) #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarboMuffin
reviewed
Jul 28, 2023
GarboMuffin
reviewed
Jul 28, 2023
GarboMuffin
reviewed
Jul 28, 2023
GarboMuffin
reviewed
Jul 28, 2023
|
Ok give me a minute I forgot to use the github version and used the version
on my local hard drive by accident lol.
…On Thu, Jul 27, 2023, 10:27 PM GarboMuffin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In extensions/obviousAlexC/newgroundsIO.js
<#792 (comment)>:
> @@ -5883,7 +6668,7 @@
this.#status = NewgroundsIO.SessionState.WAITING_FOR_USER;
this.mode = "check";
- Scratch.openWindow(this.passport_url);
+ Scratch.openWindow(this.passport_url, "_blank");
same again _blank doesn't do anything
—
Reply to this email directly, view it on GitHub
<#792 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASKLQSNGIJRWNM3F4URWJHDXSMPPJANCNFSM6AAAAAA223TRFA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
hope you tested this, i did not |
From what I had seen the login was the issue. I did test the problem spot there since that was what was reported to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem with logging in!