Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacked Blocks Collection tweaks #969

Merged
merged 7 commits into from
Aug 28, 2023

Conversation

pumpkinhasapatch
Copy link
Contributor

@pumpkinhasapatch pumpkinhasapatch commented Aug 27, 2023

Resolves #960
This makes some changes to LilyMakesThings' Hacked Blocks Collection extension.

  • Rename the extension from Hacked Block Collection to Hidden Blocks (suggested by NexusKitten)
  • Add Documentation button linking to https://en.scratch-wiki.info/wiki/Hidden_Blocks that explains each block in more detail
  • Change the dropdown in when this sprite touches ( ) block to a sensing menu to also list other sprites, since the block supports it
  • Remove sensing reporters with string inputs (these can be worked around by dragging a join block into their normal variants)
  • Move the Pen hex reporter below control blocks, and add Music note and micro:bit dot matrix "pixel art" reporters.

It also adds a screenshot image into the extension gallery showing some of the blocks.
image

Try it out here!

- Rename extension from Hacked Block Collection to Hidden Blocks
- Add Documentation button linking to https://en.scratch-wiki.info/wiki/Hidden_Blocks
- Remove sensing reporters with string inputs (these can be worked around by dragging a join block into their normal variants)
- Move pen hex reporter into it's own subcategory, and add music note and micro:bit matrix reporters.
Just a screenshot of a few quirky blocks from the extension
Copy link
Contributor

@LilyMakesThings LilyMakesThings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is brilliant, I left some comments

extensions/Lily/HackedBlocks.js Outdated Show resolved Hide resolved
extensions/Lily/HackedBlocks.js Outdated Show resolved Hide resolved
@@ -26,38 +29,37 @@
xml: '<block id="while" type="control_while"/>',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right in that we should remove "while", I left it in by mistake while testing the extension. It doesn't need to be here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I think we should remove while from the regular Control category and keep it in this extension. I've never used it and it is the only block that has been changed in the entire default block palette now that for is gone.

Copy link
Contributor

@LilyMakesThings LilyMakesThings Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People were putting in issues when the "for" loop was removed, claiming it was a bug (and that was necessary to fix some strange behaviours).

Removing "while" from the main palette, while certainly the desirable option, is not a good idea

Copy link
Contributor Author

@pumpkinhasapatch pumpkinhasapatch Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being one of those people, I was annoyed that there was no way to get the for loop back if I still needed it other than searching for an existing project that has the block or hacking it in myself.

With this, we only need to mention that the while loop has been transferred to an extension category (like when Music and Pen were moved in 3.0's release) and you can easily get it back by importing Hidden Blocks.

@GarboMuffin
Copy link
Member

can you find a way to fit the word "hacked blocks" into the description so it shows up when people search for that?

Copy link
Contributor Author

@pumpkinhasapatch pumpkinhasapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the for loop would be less buggy if we changed the default variable from "i" to the "my variable" that already exists in default projects. Can't figure out how to set the value though since there's almost no documentation for Scratch.BlockType.XML.

@LilyMakesThings
Copy link
Contributor

I think the for loop would be less buggy if we hanged the default variable from "i" to the "my variable" that already exists in default projects. Can't figure out how to set the value though.

That wouldn't resolve it fully, because you can just deleted "my variable" (like many people do), and the problem starts up again.

@GarboMuffin GarboMuffin merged commit ca2a9dc into TurboWarp:master Aug 28, 2023
3 checks passed
@pumpkinhasapatch
Copy link
Contributor Author

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions for Hacked Blocks
4 participants