Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badges and workflows #18

Merged
merged 3 commits into from Apr 12, 2021
Merged

Update badges and workflows #18

merged 3 commits into from Apr 12, 2021

Conversation

devmotion
Copy link
Member

I completely missed that the package uses main and not master as default branch (BTW CompatHelper seems to work, it also noticed that a key COMPATHELPER_PRIV exists).

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #18 (7ca790e) into main (b315b92) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files           1        1           
  Lines          57       57           
=======================================
  Hits           47       47           
  Misses         10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d31764...7ca790e. Read the comment docs.

@devmotion
Copy link
Member Author

Actually, it seems although there exists a key it is invalid: https://github.com/TuringLang/AbstractPPL.jl/runs/2292433814?check_suite_focus=true#step:3:28 Therefore #19 did not trigger CI tests.

@phipsgabler
Copy link
Member

Maybe I copied something wrongly. I generated and added a new key pair now.

@phipsgabler
Copy link
Member

Is that enough of a check that this is good now: https://github.com/TuringLang/AbstractPPL.jl/runs/2303403984?check_suite_focus=true? Or will the trigger work differently if there is actually something to update?

@devmotion
Copy link
Member Author

Unfortunately, it doesn't ensure that it's correct. The (possibly resolved) problem occurs only when CompatHelper actually opens a PR. Without the key or an incorrect key it can't trigger any other Github actions but this is not relevant for the check if any newer versions exist.

@phipsgabler
Copy link
Member

Hm, I thought we would notice it the next time CompatHelper runs, but appearently that is not so often. Do you think I should just merge and wait, or wait for a test case, first?

@devmotion
Copy link
Member Author

Oh CompatHelper runs every day at midnight but the error only occurs (or hopefully not anymore...) if it opens a PR which doesn't happen too often since the package only depends on AbstractMCMC IIRC.

@devmotion
Copy link
Member Author

So I'd merge the PR without checking it - the worst thing that can happen is that it does not work the next time CompatHelper opens a PR and one has to close and reopen its PR manually to trigger the CI tests.

@phipsgabler phipsgabler merged commit 82c210c into main Apr 12, 2021
@phipsgabler phipsgabler deleted the dw/master branch April 12, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants