Clean-up for new release #31
Merged
+41
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1217664546Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage 77.77% 77.77%
=======================================
Files 1 1
Lines 108 108
=======================================
Hits 84 84
Misses 24 24
Continue to review full report at Codecov.
|
torfjelde
commented
Sep 9, 2021
|
|
||
| function VarName{sym}(indexing=IdentityLens()) where {sym} | ||
| function VarName{sym}(lens=IdentityLens()) where {sym} | ||
| # TODO: Should we completely disallow or just `@warn` of limited support? |
There was a problem hiding this comment.
IMO we disallow for now, and then we can consider enabling dynamic lenses if we have a good use-case for it.
|
This should be a pretty quick review btw; only renaming somethings:) |
yebai
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some minor left-over work from the lens-PR. This PR does that work. AFAIK we should be good for a release after this.