Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Setfield to 0.8, (keep existing compat) #32

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Setfield package from 0.7.1 to 0.7.1, 0.8.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@phipsgabler phipsgabler force-pushed the compathelper/new_version/2021-09-17-00-08-11-372-02490650779 branch from f2849bf to 0563123 Compare September 17, 2021 00:08
@coveralls
Copy link

coveralls commented Sep 17, 2021

Pull Request Test Coverage Report for Build 1243639326

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.778%

Totals Coverage Status
Change from base Build 1217811956: 0.0%
Covered Lines: 84
Relevant Lines: 108

💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #32 (0563123) into main (76f64dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files           1        1           
  Lines         108      108           
=======================================
  Hits           84       84           
  Misses         24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f64dd...0563123. Read the comment docs.

@yebai yebai merged commit 12714ad into main Sep 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the compathelper/new_version/2021-09-17-00-08-11-372-02490650779 branch September 20, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants