Deepcopy model in LibtaskModel (#92)

* Move things around * Add test, fix comments * Copy * Update Project.toml --------- Co-authored-by: Hong Ge <hg344@cam.ac.uk>
TuringLang · Nov 9, 2023 · 1e5dfdd · 1e5dfdd · yebai · Nov 9, 2023
1 parent 955a562
commit 1e5dfdd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "AdvancedPS"
 uuid = "576499cb-2369-40b2-a588-c64705576edc"
 authors = ["TuringLang"]
-version = "0.5.3"
+version = "0.5.4"
 
 [deps]
 AbstractMCMC = "80f14c24-f653-4e6a-9b94-39d6b0f70001"

diff --git a/ext/AdvancedPSLibtaskExt.jl b/ext/AdvancedPSLibtaskExt.jl
@@ -32,8 +32,13 @@ function AdvancedPS.LibtaskModel(
     )
 end
 
+"""
+    copy(model::AdvancedPS.LibtaskModel)
+
+The task is copied (forked) and the inner model is deepcopied.
+"""
 function Base.copy(model::AdvancedPS.LibtaskModel)
-    return AdvancedPS.LibtaskModel(model.f, copy(model.ctask))
+    return AdvancedPS.LibtaskModel(deepcopy(model.f), copy(model.ctask))
 end
 
 const LibtaskTrace{R} = AdvancedPS.Trace{<:AdvancedPS.LibtaskModel,R}