Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSMProblems integration #97

Merged
merged 6 commits into from
Apr 15, 2024
Merged

SSMProblems integration #97

merged 6 commits into from
Apr 15, 2024

Conversation

FredericWantiez
Copy link
Member

@FredericWantiez FredericWantiez commented Mar 24, 2024

The two main issues I see with the current API in SSMProblems:

  • Handling of observations, I wrapped them up in the model and the user has to deal with it.
  • Couldn't easily remove AdvancedPS.isdone

Fixes: #93; Fixes: #94

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (1e5dfdd) to head (804bda0).

❗ Current head 804bda0 differs from pull request most recent head e834cd9. Consider uploading reports for the commit e834cd9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   96.09%   95.60%   -0.49%     
==========================================
  Files           8        8              
  Lines         410      410              
==========================================
- Hits          394      392       -2     
- Misses         16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Mar 24, 2024

Pull Request Test Coverage Report for Build 8667027991

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 95.61%

Files with Coverage Reduction New Missed Lines %
ext/AdvancedPSLibtaskExt.jl 2 91.25%
Totals Coverage Status
Change from base Build 6816722471: -0.5%
Covered Lines: 392
Relevant Lines: 410

💛 - Coveralls

@THargreaves
Copy link
Contributor

This looks good to me. Happy for this to replace the previous partial PRs.

Wrapping the observations in the model seems like a sensible approach for now.

@FredericWantiez
Copy link
Member Author

@yebai

@yebai yebai marked this pull request as ready for review April 12, 2024 19:26
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FredericWantiez, good work! Feel free to merge this!

@yebai yebai merged commit 2880bd3 into master Apr 15, 2024
18 checks passed
@yebai yebai deleted the fred/api branch April 15, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants