Skip to content

Commit

Permalink
Some fixes (#114)
Browse files Browse the repository at this point in the history
* Define `eachcol` in optional AD backends

* Disable tests on Windows for now

* Disable tests on 32bit as well
  • Loading branch information
devmotion committed Jun 17, 2020
1 parent a72665d commit 5216dd6
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 4 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ForwardDiff_Tracker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
os:
- ubuntu-latest
- macOS-latest
- windows-latest
arch:
- x64
steps:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ReverseDiff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
os:
- ubuntu-latest
- macOS-latest
- windows-latest
arch:
- x64
steps:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/Zygote.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
os:
- ubuntu-latest
- macOS-latest
- windows-latest
arch:
- x64
steps:
Expand Down
4 changes: 3 additions & 1 deletion src/compat/reversediff.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ using ..Bijectors: Log, SimplexBijector, maphcat, simplex_link_jacobian,
ReverseDiffAD, Inverse
import ..Bijectors: _eps, logabsdetjac, _logabsdetjac_scale, _simplex_bijector,
_simplex_inv_bijector, replace_diag, jacobian, getpd, lower

using Compat: eachcol
using Distributions: LocationScale

# AD implementations
Expand Down Expand Up @@ -178,4 +180,4 @@ lower(A::TrackedMatrix) = track(lower, A)
return lower(Ad), Δ -> (lower(Δ),)
end

end
end
2 changes: 2 additions & 0 deletions src/compat/tracker.jl
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ using .Tracker: Tracker,
track,
data,
param

using Compat: eachcol
using LinearAlgebra

maporbroadcast(f, x::TrackedArray...) = f.(x...)
Expand Down
2 changes: 2 additions & 0 deletions src/compat/zygote.jl
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
using .Zygote: Zygote, @adjoint, @nograd, pullback

using Compat: eachcol

@adjoint istraining() = true, _ -> nothing
@nograd Bijectors._debug

Expand Down

0 comments on commit 5216dd6

Please sign in to comment.