Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update flux @functor on the nf example #161

Closed
wants to merge 1 commit into from
Closed

update flux @functor on the nf example #161

wants to merge 1 commit into from

Conversation

themrzmaster
Copy link

as described here FluxML/Flux.jl#1339, treelike has been removed.

@themrzmaster
update flux functor on the example
b296bae 
as described here FluxML/Flux.jl#1339, treelike has been removed.
@devmotion
Copy link
Member

Functors.@functor is just reexported by Flux, so probably the better approach would be to just implement Functors.functor and Functors.@functor it in the package and remove it completely from the README. I have some local fixes and will open a PR in the next days.

@devmotion devmotion mentioned this pull request Jan 10, 2021
Merged
@devmotion
Copy link
Member

Fixed by #162.

@devmotion devmotion closed this Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@themrzmaster @devmotion