Addressing #85 #86
Merged
Addressing #85 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think just having the dist params is fine for now, but it would probably be ideal down the line to include the transform ones as well (though potentially in a different method.) The reason I opened this issue (#85), by the way, was to check compatibility with |
|
Wait! |
|
Should be good now, as long as the tests pass 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
StatsBase.paramsforTransformedDistribution, andBase.maximum, Base.minimumforUnivariateTransformedDistribution.Up for discussion
StatsBase.paramsonly returns the parameters of the underlying base distribution, i.e.params(td.dist). In the case where in addition theBijectorhas parameters, is it then expected that these are also included in the return-value ofparams? Uncertain what makes the most sense. If so, this does increase the complexity of this PR a fair bit as it's not 100% clear how we'd do that in a nice way.