Merge pull request #20 from devmotion/fix2

Fix method ambiguity
TuringLang · Jan 14, 2020 · 42288a7 · 42288a7
2 parents 52af507 + f03f2de
commit 42288a7
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/common.jl b/src/common.jl
@@ -115,6 +115,4 @@ end
 ## PDMats ##
 
 PDMats.invquad(Σ::PDiagMat, x::Tracker.TrackedVector) = sum(abs2.(x) ./ Σ.diag)
-getchol(m::PDMats.AbstractPDMat) = m.chol
-getchol(m::PDMats.PDiagMat) = cholesky(Diagonal(m.diag))
-getchol(m::PDMats.ScalMat) = cholesky(Diagonal(fill(m.value, m.dim)))
+PDMats.invquad(Σ::PDMat, x::Tracker.TrackedVector) = sum(abs2, zygote_ldiv(Σ.chol.L, x))