Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopening of previous PR #309

Merged
merged 262 commits into from
Dec 12, 2021
Merged

Reopening of previous PR #309

merged 262 commits into from
Dec 12, 2021

Conversation

torfjelde
Copy link
Member

@torfjelde torfjelde commented Aug 19, 2021 •
edited by yebai

What we need before merge:

  1. Updated benchmarks.
  2. Resolve comments.

torfjelde and others added 30 commits June 1, 2021 00:43
@torfjelde
fixed some signatures for Model
a0c05f3
@torfjelde
fixed a method call
307cd7e
@torfjelde
fixed method signatures
5972771
@torfjelde
sort of fixed the matchingvalue functionality for model
c4ecd0e
@torfjelde
formatting
a34b51c
@torfjelde
removed redundant _tilde method
b89ff7e
@torfjelde
Merge branch 'tor/tilde-simplification' into tor/sampler-context
6368282
@torfjelde
removed left-over acclogp! that should not be here anymore
e4a2cf8
@torfjelde
export SamplingContext
7605785
@torfjelde
use context instead of ctx to refer to contexts
354ac52
@torfjelde
formatting
b7a2b3b
@torfjelde
use context instead of ctx for variables
9e0fc9a
@torfjelde
use context instead of ctx to refer to contexts
7a4a1a3
@torfjelde @devmotion
Update src/compiler.jl
7899473 
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@torfjelde @devmotion
Update src/context_implementations.jl
1630476 
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@torfjelde @devmotion
Apply suggestions from code review
6892d2b 
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@torfjelde
added some whitespace to some docstrings
13da1b4
@torfjelde
deprecated tilde and dot_tilde plus exported new versions
d76e5b3
@torfjelde @github-actions
formatting
8059669 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yebai
Merge branch 'master' into tor/tilde-simplification
4343896
@torfjelde
minor version bump
43ef8d1
@torfjelde
Merge branch 'master' into tor/sampler-context
fec00b6
@torfjelde
Merge branch 'master' into tor/sampler-context
ffb4933
@torfjelde
Merge branch 'master' into tor/tilde-simplification
43356a2
@torfjelde
Merge branch 'master' into tor/tilde-simplification
671e0b7
@torfjelde
Merge branch 'tor/tilde-simplification' into tor/sampling-context-simple
30c8345
@torfjelde
added impl of matchingvalue for contexts
1015f0e
@torfjelde
reverted the change that makes assume always resample
23c86a7
@torfjelde
removed the inds arguments from assume and dot_assume to stay non-bre…
17f5abe 
…aking
@yebai @github-actions
Update src/context_implementations.jl
dbd61f0 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bors bot pushed a commit that referenced this pull request Dec 8, 2021
@torfjelde @yebai
Reopening of previous PR (#309)
e1a8111 
What we need before merge:
1. [x] Updated benchmarks.
2. [ ] Resolve comments.

Co-authored-by: Hong Ge <hg344@cam.ac.uk>
@bors
Copy link
Contributor

bors bot commented Dec 8, 2021

Build failed:

@torfjelde
Copy link
Member Author

bors try

@bors
Copy link
Contributor

bors bot commented Dec 11, 2021

try

Already running a review

@torfjelde
Copy link
Member Author

bors try

@bors
Copy link
Contributor

bors bot commented Dec 11, 2021

try

Already running a review

@torfjelde
Copy link
Member Author

bors try

@bors
Copy link
Contributor

bors bot commented Dec 11, 2021

try

Already running a review

@yebai
Copy link
Member

yebai commented Dec 11, 2021

Bors try

@bors
Copy link
Contributor

bors bot commented Dec 11, 2021

try

Already running a review

@yebai
Copy link
Member

yebai commented Dec 11, 2021

Let me know if you want me to merge this PR manually - Bors seems on strike again. @torfjelde

@yebai yebai merged commit 1744ba7 into master Dec 12, 2021
@yebai yebai deleted the tor/simple-varinfo-v2 branch December 12, 2021 10:27
@bors
Copy link
Contributor

bors bot commented Dec 12, 2021

try

Timed out.

@yebai yebai mentioned this pull request Dec 12, 2021
Closed
@torfjelde torfjelde mentioned this pull request Dec 14, 2021
Closed
bors bot pushed a commit that referenced this pull request Dec 14, 2021
@torfjelde
Hotfixes after #309 (#351)
337a5e3 
#309 was merged a bit too soon, for example `bors` was never run on the final version due to some issues. Before we make a release, we should make sure that it all works properly.
bors bot pushed a commit that referenced this pull request Dec 14, 2021
@torfjelde
Hotfixes after #309 (#351)
b60bd84 
#309 was merged a bit too soon, for example `bors` was never run on the final version due to some issues. Before we make a release, we should make sure that it all works properly.
bors bot pushed a commit that referenced this pull request Dec 14, 2021
@torfjelde
Hotfixes after #309 (#351)
2dfa59b 
#309 was merged a bit too soon, for example `bors` was never run on the final version due to some issues. Before we make a release, we should make sure that it all works properly.
bors bot pushed a commit that referenced this pull request Dec 14, 2021
@torfjelde
Hotfixes after #309 (#351)
2a0258c 
#309 was merged a bit too soon, for example `bors` was never run on the final version due to some issues. Before we make a release, we should make sure that it all works properly.
bors bot pushed a commit that referenced this pull request Dec 14, 2021
@torfjelde
Hotfixes after #309 (#351)
0bb2504 
#309 was merged a bit too soon, for example `bors` was never run on the final version due to some issues. Before we make a release, we should make sure that it all works properly.
This was referenced Dec 16, 2021
Closed
Closed
Closed
Closed
Closed
Closed
@yebai yebai mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion devmotion left review comments

@yebai yebai yebai approved these changes

@phipsgabler phipsgabler phipsgabler left review comments

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@torfjelde @yebai @devmotion @phipsgabler