Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper support for distributions with embedded support #462
Proper support for distributions with embedded support #462
Changes from 67 commits
fc16d3e
a0de0ac
4fe5eea
dfaf7be
8d77d78
16ac9e1
2e3b006
425ca5d
c1f0b3b
73f4bd2
1b3c581
c2fbded
3b156db
6070e3f
613eb1b
0af6e29
0fcd481
29faba0
cc1bb7b
2501510
6957e2e
90a3edb
7817920
ade35c8
d7841e5
7a6ef1b
360283f
d958d84
3cf6e07
a25891d
02dd8bf
4765ea9
f02fdd9
603e027
de47598
8cd2610
752e40b
b0a67a9
2765b08
ed03864
96c0690
7b5521d
595d9ee
d81217e
9b516b8
61e832b
d06cc8a
dbecece
aa76c08
f756e44
9785594
78e6332
cec5bd3
b6dc3ec
f126448
1e4d688
b9a8c16
e3ce20d
e5d19a8
ba7c24c
bf73961
eec87ee
42ed9df
6fa0f72
3d5ead3
64c3a07
3fd55d4
e683cce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, that's confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really want to remove this entire function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this is untested and causes method ambiguity issues (when eg tested with test_method_ambiguities).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know of this
test_method_ambiguities
; can you elaborate or point me somewhere?