Fixes for SimpleVarInfo with Ref
#527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yebai
approved these changes
Sep 1, 2023
| lp = getlogp(vi_typed) | ||
| return map((vi_untyped, vi_typed, svi_typed, svi_untyped)) do vi | ||
| return map(( |
There was a problem hiding this comment.
It's slightly strange that we performed a functionality test for setlogp!! inside this utility function.
There was a problem hiding this comment.
Hmm, maybe. But it's really not something we rely on. This is just to make the varinfos as consistent with each other as possible, i.e. they should have the same values and the same logp.
Alternatively, we can always just use zero instead, but then that would also require setlogp!! 😕
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
==========================================
+ Coverage 80.40% 80.64% +0.23%
==========================================
Files 24 24
Lines 2776 2779 +3
==========================================
+ Hits 2232 2241 +9
+ Misses 544 538 -6
☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 6048032021
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VarInfousesReffor its logp-field, partially because it makes us compatible with Zygote.jl; Zygote.jl does support differentiating through mutations ofRef, though it's slow: FluxML/Zygote.jl#999By default,
SimpleVarInfodoes not mutate itslogpfield, and so it uses a simpleRealinstead of aRefValue{<:Real}. This then works fine with Zygote because no mutation occurs, until we start using threads, in which case we're working with aVector{<:Real}instead ofVector{<:RefValue{<:Real}}, as is done by default withVarInfo.This can cause some issues when Julia is started with threads, e.g. https://discourse.julialang.org/t/error-running-museinference-jl-example/103360/4.
This PR adds more testing for
SimpleVarInfowithRef+ a fix allowing proper usage with threads.