Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added back prob and logprob macros #609

Merged
merged 5 commits into from
May 17, 2024

Conversation

torfjelde
Copy link
Member

#604 removed these two macros, but this will just result in ambiguous errors for lots of users (this feature has been displayed in the Turing.jl docs and we know there are people using it) without telling them anything about why the changes was made.

This PR makes them instead error, providing some information on where to find discussion + how to "replace" some of its functionality.

src/DynamicPPL.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@sunxd3 sunxd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@torfjelde torfjelde enabled auto-merge May 17, 2024 10:28
@coveralls
Copy link

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build 9126744062

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 77.596%

Totals Coverage Status
Change from base Build 9126213178: 0.03%
Covered Lines: 2653
Relevant Lines: 3419

💛 - Coveralls

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.27%. Comparing base (5b53be7) to head (6f15c32).
Report is 3 commits behind head on master.

Current head 6f15c32 differs from pull request most recent head bedb345

Please upload reports for the commit bedb345 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   76.93%   76.27%   -0.66%     
==========================================
  Files          30       29       -1     
  Lines        3572     3439     -133     
==========================================
- Hits         2748     2623     -125     
+ Misses        824      816       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torfjelde torfjelde added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit 0d4962e May 17, 2024
11 of 12 checks passed
@torfjelde torfjelde deleted the torfjelde/probmacro-error-with-info branch May 17, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants