Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Distributions" to "0.24" #242

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 8, 2020

This pull request changes the compat entry for the Distributions package from 0.21, 0.22, 0.23 to 0.21, 0.22, 0.23, 0.24.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #242 into master will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   72.54%   73.06%   +0.52%     
==========================================
  Files          20       20              
  Lines        1242     1240       -2     
==========================================
+ Hits          901      906       +5     
+ Misses        341      334       -7     
Impacted Files Coverage Δ
src/summarize.jl 69.84% <100.00%> (+9.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0208256...42decea. Read the comment docs.

@devmotion
Copy link
Member

Can't be tested with Distributions 0.24 since KernelDensity is not compatible with it yet.

@devmotion devmotion closed this Oct 8, 2020
@devmotion devmotion reopened this Oct 8, 2020
@devmotion
Copy link
Member

Requires also a new version of https://github.com/alan-turing-institute/MLJModels.jl.

@devmotion devmotion closed this Oct 16, 2020
@devmotion devmotion reopened this Oct 16, 2020
@devmotion
Copy link
Member

OK, requires even an update of MLJ.

@devmotion
Copy link
Member

Actually, MLJ is not needed and can be removed from the tests.

@devmotion devmotion merged commit cd85b9a into master Oct 16, 2020
@devmotion devmotion deleted the compathelper/new_version/2020-10-08-00-04-09-296-4292607743 branch October 16, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant