Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sampling from multiple chains #365

Merged
merged 5 commits into from May 1, 2022
Merged

Fix sampling from multiple chains #365

merged 5 commits into from May 1, 2022

Conversation

devmotion
Copy link
Member

Fixes #223. This came up also in TuringLang/TuringTutorials#296.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #365 (b61bebf) into master (29d6b14) will increase coverage by 0.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   83.14%   83.61%   +0.46%     
==========================================
  Files          19       19              
  Lines         991      995       +4     
==========================================
+ Hits          824      832       +8     
+ Misses        167      163       -4     
Impacted Files Coverage Δ
src/sampling.jl 100.00% <100.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d6b14...b61bebf. Read the comment docs.

Copy link
Member

@cpfiffer cpfiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpfiffer cpfiffer merged commit f08853a into master May 1, 2022
@cpfiffer cpfiffer deleted the dw/sample branch May 1, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected number of samples returned from sample
2 participants