-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information on methods for mcse #16
Conversation
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 94.39% 94.39%
=======================================
Files 8 8
Lines 553 553
=======================================
Hits 522 522
Misses 31 31
Continue to review full report at Codecov.
|
Thanks for the feedback, David. Let me know if I can also update the MCMCChains docs. I'm not sure what you want with that exactly. For me, closing that PR is also fine if you plan to merge the migration to InferenceDiagnostics.jl soon(ish). |
According to Benjamin Deonovic on Slack. The methods are based on other calculations. Don't merge yet, I'll add refs. |
Okay. Updated it. Are the refs okay like this? I see that you also use
but that isn't so useful here. Alternatively, we can move the docs in the different methods and add a bunch of |
I think it's fine as it is. IIRC I did not use cross references since I was not satisfied with the Documenter output (e.g., there are issues with references that appear in different docstrings (JuliaDocs/Documenter.jl#566) but maybe this is not an issue anymore since I removed the references from |
I plan to register the package within the next days (#2 (comment)) and there is already a PR for MCMCChains, so I assume the migration can be completed until the end of next week. So maybe we can just wait until end of next week and merge the PR to MCMCChains only if it is not fixed until then? |
Completely fine by me :) I'll just close the other PR for now. |
Thanks for the PR! |
No description provided.