-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ParticleSampler
and HMCSampler
into Sampler
?
#174
Comments
This makes sense. I'm also thinking the new sampler should somehow make it easier for different samplers to share some basic functions like |
This |
We should consider store run time information in |
I think it's bit weird that all samplers should have a filed of |
@yebai I'm sorry that I pushed my commits (for this issue) directly to the master by mistake. Can you have a look at them? |
It's OK. I will take a look and comment on the master branch. |
After introducing
VarInfo
and the new compiler interface, it seems possible to merge some sampler classes into a single one, e.g.In addition, to query sampler specific information (e.g. gradient sampler, particle sampler), we might consider introduce the following generic APIs for sampler
The text was updated successfully, but these errors were encountered: