Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no tests #2028

Merged
merged 2 commits into from
Jul 4, 2023
Merged

no tests #2028

merged 2 commits into from
Jul 4, 2023

Conversation

JaimeRZP
Copy link
Member

@JaimeRZP JaimeRZP commented Jul 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (22cdfeb) 0.00% compared to head (ae6c55c) 0.00%.

Additional details and impacted files
@@                          Coverage Diff                          @@
##           torfjelde/allow-abstractsampler-draft   #2028   +/-   ##
=====================================================================
  Coverage                                   0.00%   0.00%           
=====================================================================
  Files                                         22      22           
  Lines                                       1462    1462           
=====================================================================
  Misses                                      1462    1462           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yebai yebai marked this pull request as ready for review July 4, 2023 18:25
@yebai yebai merged commit b08dd82 into torfjelde/allow-abstractsampler-draft Jul 4, 2023
13 checks passed
@yebai yebai deleted the no_tests branch July 4, 2023 18:25
yebai added a commit that referenced this pull request Jul 5, 2023
* initial work on allowing AdvancedHMC samplers

* simplify the hacky initialize_nuts method

* slight generalization

* remove unnecessary type constraint

* rever changes to sample overloads

* use a subtype of InferenceAlgorithm to wrap any sampler

* improve usage of SamplerWrapper

* renamed hmc_new.jl to something a bit more indicative

* added support for AdvancedMH

* forgot to change include

* renamed SamplerWrapper to ExternalSampler and provided a function externalsampler

* added tests for Advanced{HMC,MH}

* fixed external tests

* change target acceptance rate

* fixed optim tests

* remove NelderMead from tests

* allow models with one variance parameter per observation to fail MLE test

* no tests (#2028)

* no tests

* more tol

---------

Co-authored-by: Jaime RZ <jaimerz011235813@gmail.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants